Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing type conversation #69

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Conversation

urso
Copy link

@urso urso commented Oct 5, 2016

Some edge cases using environment variables or direct conversation
including floating values have been shown to fail

  • add direct support for float conversation by identifying if target
    type is float + support casting int/uint to float
  • string type can be parsed/converted to types bool, int, uint and float.
    In few cases, strings for numberic values have been read from yaml and
    put into ucfg (e.g. user using quotes, environment variable
    expansion).
    Allowing to convert strings dynamically to primitives solves some
    failing edge cases (new unit tests included).

Resolves: #67, #68

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Some edge cases using environment variables or direct conversation
including floating values have been shown to fail

- add direct support for float conversation by identifying if target
  type is float + support casting int/uint to float

- string type can be parsed/converted to types bool, int, uint and float.
  In few cases, strings for numberic values have been read from yaml and
  put into ucfg (e.g. user using quotes, environment variable
  expansion).
  Allowing to convert strings dynamically to primitives solves some
  failing edge cases (new unit tests included).
@urso urso force-pushed the fix/string-type-conv branch from 10cd3f1 to 8769aea Compare October 5, 2016 12:11
@urso urso added the review label Oct 5, 2016
@ruflin ruflin merged commit 8bd03a9 into elastic:master Oct 5, 2016
@urso urso deleted the fix/string-type-conv branch October 5, 2016 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants